Commit graph

871 commits

Author SHA1 Message Date
dependabot[bot]
4bf3685328
build(deps): bump the deps group with 3 updates (#1954)
Bumps the deps group with 3 updates: [thiserror](https://github.com/dtolnay/thiserror), [url](https://github.com/servo/rust-url) and [fs4](https://github.com/al8n/fs4-rs).


Updates `thiserror` from 1.0.66 to 1.0.68
- [Release notes](https://github.com/dtolnay/thiserror/releases)
- [Commits](https://github.com/dtolnay/thiserror/compare/1.0.66...1.0.68)

Updates `url` from 2.5.2 to 2.5.3
- [Release notes](https://github.com/servo/rust-url/releases)
- [Commits](https://github.com/servo/rust-url/compare/v2.5.2...v2.5.3)

Updates `fs4` from 0.10.0 to 0.11.0
- [Release notes](https://github.com/al8n/fs4-rs/releases)
- [Commits](https://github.com/al8n/fs4-rs/commits)

---
updated-dependencies:
- dependency-name: thiserror
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: deps
- dependency-name: url
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: deps
- dependency-name: fs4
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: deps
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-05 10:36:13 +00:00
github-actions[bot]
2c1f156332
release: cargo-binstall v1.10.10 (#1951)
chore: Release

Co-authored-by: github-actions <github-actions@github.com>
2024-11-02 02:45:51 +00:00
github-actions[bot]
8644e54e84
chore: release (#1944)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-11-02 01:25:13 +00:00
Jiahao XU
a944df0498
Improve UI orompt for installation (#1950)
Fixed #1943

The UI now looks like

```
WARN The package cargo-binstall v1.10.9 (aarch64-apple-darwin) has been downloaded from github.com
INFO This will install the following binaries:
INFO   - cargo-binstall => /tmp/e/bin/cargo-binstall
````

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
2024-11-02 00:52:37 +00:00
pepa65
81a8218794
Yes/NO defaults to "no" when just enter is pressed (#1948)
* yes/NO in interface

* Implement No as default (when only Enter is pressed)

* Update README.md

Mark the default as [yes]

Signed-off-by: pepa65 <pepa65@passchier.net>

* Update ui.rs

Mark the default as [yes]

Signed-off-by: pepa65 <pepa65@passchier.net>

* Update ui.rs

Do not break on yes/y/YES/Y/"", break on no/n/NO/N, and keep asking otherwise

Signed-off-by: pepa65 <pepa65@passchier.net>

* Update ui.rs

After testing empty didn't work correctly

Signed-off-by: pepa65 <pepa65@passchier.net>

---------

Signed-off-by: pepa65 <pepa65@passchier.net>
2024-10-30 13:00:56 +00:00
Jiahao XU
e704abe7ac
Use rc-zip-sync for zip extraction (#1942)
* Use rc-zip-sync for zip extraction

Fixed #1080

In this commit, binstalk-downloader is updated to
- first download the zip into a temporary file, since
  there is no correct way to extract zip from a stream.
- then use rc-zip-sync to read from the zip and extract
  it to filesystem.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

* Fix returned `ExtractedFiles` in `do_extract_zip`

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix clippy in zip_extraction.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

---------

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
2024-10-30 00:16:54 +00:00
github-actions[bot]
c16790a16f
release: cargo-binstall v1.10.9 (#1941)
chore: Release

Co-authored-by: github-actions <github-actions@github.com>
2024-10-26 02:51:55 +00:00
github-actions[bot]
afd20e9396
chore: release (#1937)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-10-26 01:49:47 +00:00
github-actions[bot]
4675f622c9
release: cargo-binstall v1.10.8 (#1931)
chore: Release

Co-authored-by: github-actions <github-actions@github.com>
2024-10-13 00:45:03 +00:00
github-actions[bot]
731592f357
chore: release (#1933)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-10-12 15:08:00 +00:00
PukNgae Cryolitia
5069cb6638
fix(gh_api_client): remote client should never being shared everywhere bacause the underlying connection pool will be reused. (#1930)
The client pool contains connections associated with a runtime when the runtime closes, the client may panic at seeing the connection disappear "abruptly".

Reported-by: https://archriscv.felixc.at/.status/log.htm?url=logs/cargo-binstall/cargo-binstall-1.8.0-1.log
Link: https://github.com/seanmonstar/reqwest/issues/1148
2024-10-12 12:32:04 +00:00
Jiahao XU
61c9231401
CI: Fix binstalk-git-repo-api on PR of forks (#1932)
* Rm CI_UNIT_TEST_GITHUB_TOKEN fallback for unit-tests

As it would break unit testing

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* CI: Fix gh_api_client.rs test

Ignore empty gh token

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Update crates/binstalk-git-repo-api/src/gh_api_client.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Update crates/binstalk-git-repo-api/src/gh_api_client.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

---------

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
2024-10-12 10:12:53 +00:00
github-actions[bot]
a8227ae6a4
chore: release (#1928)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-10-12 03:58:24 +00:00
dependabot[bot]
e7f98b2a3d
build(deps): bump fs4 from 0.9.1 to 0.10.0 in the deps group (#1929)
Bumps the deps group with 1 update: [fs4](https://github.com/al8n/fs4-rs).


Updates `fs4` from 0.9.1 to 0.10.0
- [Release notes](https://github.com/al8n/fs4-rs/releases)
- [Commits](https://github.com/al8n/fs4-rs/commits/0.10.0)

---
updated-dependencies:
- dependency-name: fs4
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: deps
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-12 01:46:19 +00:00
github-actions[bot]
3ed2912cc1
release: cargo-binstall v1.10.7 (#1926)
chore: Release

Co-authored-by: github-actions <github-actions@github.com>
2024-10-04 12:03:43 +00:00
github-actions[bot]
a7794f08a6
chore: release (#1924)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-10-04 10:54:17 +00:00
github-actions[bot]
3a99ae3c15
release: cargo-binstall v1.10.6 (#1922)
chore: Release

Co-authored-by: github-actions <github-actions@github.com>
2024-09-22 10:17:00 +00:00
github-actions[bot]
4a15b12fd1
chore: release (#1916)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-09-22 08:59:21 +00:00
John Vandenberg
2917b32788
allow setting no_confirm via envvar (#1921) 2024-09-22 07:06:01 +00:00
github-actions[bot]
f9144d57df
release: cargo-binstall v1.10.5 (#1914)
chore: Release

Co-authored-by: github-actions <github-actions@github.com>
2024-09-11 09:06:06 +00:00
github-actions[bot]
8c9e183587
chore: release (#1911)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-09-11 08:37:44 +00:00
David Laban
c8dec953cc
report to new stats server (with status) (#1912)
* docstrings for things that I was curious about

* report to new stats server, with status

* Arc<Self> needs a clone

* fix stats url in docs

* fix stats url handling
2024-09-11 08:15:15 +00:00
Jiahao XU
a88335d05b
Improve quickinstall telemetry failure message (#1910)
Fixed #1896

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
2024-09-08 04:20:04 +00:00
github-actions[bot]
780584e44b
release: cargo-binstall v1.10.4 (#1908)
chore: Release

Co-authored-by: github-actions <github-actions@github.com>
2024-09-06 22:43:53 +00:00
github-actions[bot]
89203c196c
chore: release (#1902)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-09-06 13:37:48 +00:00
Jiahao XU
a53d51c083
Send telemetry report to quickinstall if no pre-built is found (#1905)
* Send telemetry report to quickinstall if no pre-built is found

quickinstall telemtry is overloaded cargo-bins/cargo-quickinstall#268, it only needs report when the pre-built is not available in upstream.

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix resolve.rs

And optimize sending telemtry: Remove unnecessary `<Arc as Clone>::clone`

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix fmt of resolve.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

---------

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
2024-09-05 14:43:38 +00:00
Jiahao XU
3331364a65
reduce default for maximum_resolution_timeout to 15s (#1900)
If then default is too long, then users would still have to wait a long time if they hit rate limit.

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
2024-08-29 12:45:33 +00:00
github-actions[bot]
9330730a2a
release: cargo-binstall v1.10.3 (#1898)
chore: Release

Co-authored-by: github-actions <github-actions@github.com>
2024-08-25 09:18:31 +00:00
github-actions[bot]
05bfcbce0e
chore: release (#1883)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-08-25 08:37:25 +00:00
Alejandro González
b599493600
docs: mention quickinstall telemetry collection in --help and README (#1890)
* docs: mention `quickinstall` telemetry collection in `--help` and README

These changes describe the usage statistics collected when the
`quickinstall` strategy is used by default, according to the discussion
and details brought forward on
https://github.com/cargo-bins/cargo-binstall/issues/1884. Both the
project README and the CLI long help contain clear disclosures of such
statistics collection now.

Signed-off-by: Alejandro González <me@alegon.dev>

* docs: add some more data collection details

Signed-off-by: Alejandro González <me@alegon.dev>

---------

Signed-off-by: Alejandro González <me@alegon.dev>
2024-08-20 10:24:13 +00:00
github-actions[bot]
c4abcb90a5
release: cargo-binstall v1.10.2 (#1881)
chore: Release

Co-authored-by: github-actions <github-actions@github.com>
2024-08-13 09:15:54 +00:00
github-actions[bot]
ad67d44ff6
release: cargo-binstall v1.10.1 (#1880)
chore: Release

Co-authored-by: github-actions <github-actions@github.com>
2024-08-12 14:55:46 +00:00
github-actions[bot]
2c00df4c90
chore: release (#1878)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-08-12 14:22:35 +00:00
Jiahao XU
a8eea5bc72
Enable happy eyeballs when using hickory-dns (#1877)
* Enable happy eyeballs when using hickory-dns

Ported from seanmonstar/reqwest#2378

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix imports in resolver.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix fmt in resolver.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix fmt in resolver.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix resolver.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix import on windows in resolver.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

---------

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
2024-08-11 07:26:09 +00:00
github-actions[bot]
d35fecfd64
release: cargo-binstall v1.10.0 (#1875)
chore: Release

Co-authored-by: github-actions <github-actions@github.com>
2024-08-10 08:24:15 +00:00
github-actions[bot]
53512b9271
chore: release (#1870)
* chore: release

* Bump dependents of binstall-types to next major version

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

---------

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
2024-08-10 07:46:44 +00:00
Jiahao XU
96f5445e52
dep: Bump hickory-resolver to 0.25.0-alpha.2 (#1869)
* dep: Bump hickory-resolver to 0.25.0-alpha.2

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

* Remove workaround for ring 0.16 on aarc64-pc-windows-msvc

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

---------

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
2024-08-10 04:31:24 +00:00
Jiahao XU
b854f3f52c
feature: Merge disable strategies (#1868)
* feat: Merge --disable-strategies with ones in cargo manifest

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

* Update doc

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

* Update e2e-test-strategies

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

* Fix typo in option doc in crates/bin/src/args.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

---------

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
2024-08-07 14:04:00 +00:00
github-actions[bot]
23ee8ab6b7
release: cargo-binstall v1.9.0 (#1863)
chore: Release

Co-authored-by: github-actions <github-actions@github.com>
2024-08-04 05:32:22 +00:00
github-actions[bot]
cf7c8f9656
chore: release (#1853)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-08-04 03:04:47 +00:00
Jiahao XU
52f2db4f57
Add --maximum-resolution-timeout (#1862)
* Add --maximum-resolution-timeout

Fixed #1823

* Display default value for `--maximum-resolution-timeout` in help
2024-08-04 02:13:18 +00:00
Jiahao XU
ee94b8b639
Fix: --strategies on CLI do not seem to override disabled-strategies in the manifest (#1857)
* Fix cli override in entry.rs

Forward `args.disabled_strategies`

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix `args::parse`: Do not free disabled_strategies

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix passing of cli_overrides

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Create strategies-test-override-Cargo.toml

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Add e2e-tests for cli-overrides

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix entry.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* fix entry.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix entry.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Update strategies.sh

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Compute cli_overrides in args::parse

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* fix use of args::parse main_impl.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Update entry.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix args::parse

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix typo in args.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix args.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix fmt in args.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* fix fmt in main_impl.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* update e2e-test-strategies

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Update e2e-tests/strategies.sh

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Update e2e-tests/strategies.sh

Make sure both --strategies and --disable-strategies is tested

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Update strategies.sh

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

---------

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
2024-08-03 05:27:23 +00:00
dependabot[bot]
cdbb121112
build(deps): bump the deps group across 1 directory with 2 updates (#1859)
* build(deps): bump the deps group across 1 directory with 2 updates

Bumps the deps group with 2 updates in the / directory: [fs4](https://github.com/al8n/fs4-rs) and [windows-sys](https://github.com/microsoft/windows-rs).


Updates `fs4` from 0.8.4 to 0.9.1
- [Release notes](https://github.com/al8n/fs4-rs/releases)
- [Commits](https://github.com/al8n/fs4-rs/commits)

Updates `windows-sys` from 0.52.0 to 0.59.0
- [Release notes](https://github.com/microsoft/windows-rs/releases)
- [Commits](https://github.com/microsoft/windows-rs/compare/0.52.0...0.59.0)

---
updated-dependencies:
- dependency-name: fs4
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: deps
- dependency-name: windows-sys
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: deps
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fix use of fs4

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix windows.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Rm drop impl for LibraryHandle

As unmounting dynlib might cause UB

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix clippy in windows.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
2024-08-03 05:03:10 +00:00
github-actions[bot]
f2a184de0e
release: cargo-binstall v1.8.0 (#1849)
chore: Release

Co-authored-by: github-actions <github-actions@github.com>
2024-07-26 11:34:38 +00:00
github-actions[bot]
40a083f65d
release: binstalk v0.27.0 (#1848)
chore: Release

Co-authored-by: github-actions <github-actions@github.com>
2024-07-26 10:49:28 +00:00
github-actions[bot]
091b39d278
release: binstalk-fetchers v0.8.0 (#1847)
chore: Release

Co-authored-by: github-actions <github-actions@github.com>
2024-07-26 10:21:55 +00:00
github-actions[bot]
8b314728d8
release: binstalk-registry v0.10.0 (#1846)
chore: Release

Co-authored-by: github-actions <github-actions@github.com>
2024-07-26 09:40:36 +00:00
github-actions[bot]
08d8946dde
release: binstalk-git-repo-api v0.4.0 (#1845)
chore: Release

Co-authored-by: github-actions <github-actions@github.com>
2024-07-26 09:39:17 +00:00
github-actions[bot]
40ec708bd8
release: binstalk-bins v0.5.0 (#1843)
chore: Release

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
2024-07-26 09:38:04 +00:00
github-actions[bot]
75d46eeaab
release: binstalk-manifests v0.14.0 (#1844)
chore: Release

Co-authored-by: github-actions <github-actions@github.com>
2024-07-26 09:25:15 +00:00