Fixed#1943
The UI now looks like
```
WARN The package cargo-binstall v1.10.9 (aarch64-apple-darwin) has been downloaded from github.com
INFO This will install the following binaries:
INFO - cargo-binstall => /tmp/e/bin/cargo-binstall
````
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
* yes/NO in interface
* Implement No as default (when only Enter is pressed)
* Update README.md
Mark the default as [yes]
Signed-off-by: pepa65 <pepa65@passchier.net>
* Update ui.rs
Mark the default as [yes]
Signed-off-by: pepa65 <pepa65@passchier.net>
* Update ui.rs
Do not break on yes/y/YES/Y/"", break on no/n/NO/N, and keep asking otherwise
Signed-off-by: pepa65 <pepa65@passchier.net>
* Update ui.rs
After testing empty didn't work correctly
Signed-off-by: pepa65 <pepa65@passchier.net>
---------
Signed-off-by: pepa65 <pepa65@passchier.net>
* Use rc-zip-sync for zip extraction
Fixed#1080
In this commit, binstalk-downloader is updated to
- first download the zip into a temporary file, since
there is no correct way to extract zip from a stream.
- then use rc-zip-sync to read from the zip and extract
it to filesystem.
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
* Fix returned `ExtractedFiles` in `do_extract_zip`
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
* Fix clippy in zip_extraction.rs
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
---------
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
* docstrings for things that I was curious about
* report to new stats server, with status
* Arc<Self> needs a clone
* fix stats url in docs
* fix stats url handling
* Send telemetry report to quickinstall if no pre-built is found
quickinstall telemtry is overloaded cargo-bins/cargo-quickinstall#268, it only needs report when the pre-built is not available in upstream.
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
* Fix resolve.rs
And optimize sending telemtry: Remove unnecessary `<Arc as Clone>::clone`
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
* Fix fmt of resolve.rs
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
---------
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
If then default is too long, then users would still have to wait a long time if they hit rate limit.
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
* Enable macOS dev mode in CI
to speedup CI
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
* Enable dev drive on windows to speedup CI
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
* Use dev drive for target
which is the most write-heavy part.
The read to the workspace can be cached as it is really small
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
* Setup dev drive for cargo/rust home
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
* Exclude target, cargo/rustup home from windows defender
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
* Exclude the entire workspace from
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
* Fix action.yml
Add missing shell, and merge steps for adding windows defender exclusion
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
* Fix adding windows defender exclusion path
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
* Fix use of Add-MpPreference
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
* Fix pwsh
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
* Fix creating second dev drive
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
* Fix second dev drive setup
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
* Fix caching: Do not mount dev drive at target
Since it contains files that are not accessible.
Also remove use of dev drive for cargo/rustup home since it prevents caching (rust-cache does not read from env).
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
* Disable dev drive for windows as a failed experiment
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
---------
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
* docs: mention `quickinstall` telemetry collection in `--help` and README
These changes describe the usage statistics collected when the
`quickinstall` strategy is used by default, according to the discussion
and details brought forward on
https://github.com/cargo-bins/cargo-binstall/issues/1884. Both the
project README and the CLI long help contain clear disclosures of such
statistics collection now.
Signed-off-by: Alejandro González <me@alegon.dev>
* docs: add some more data collection details
Signed-off-by: Alejandro González <me@alegon.dev>
---------
Signed-off-by: Alejandro González <me@alegon.dev>
