Improve use of github token (#1769)

* Add new dep zeroize

* Use Zeroizing to avoid leaking the token

* Optimize gh-auth-token

Spawn it as a task, and only await it
when using GhApiClient

* Fix binstalk-git-repo-api unit tests
This commit is contained in:
Jiahao XU 2024-06-15 15:42:09 +10:00 committed by GitHub
parent e3c8c40806
commit fff6aa8122
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
13 changed files with 128 additions and 54 deletions

View file

@ -6,7 +6,10 @@ use semver::VersionReq;
use crate::{
fetchers::{Data, Fetcher, SignaturePolicy, TargetDataErased},
helpers::{gh_api_client::GhApiClient, jobserver_client::LazyJobserverClient, remote::Client},
helpers::{
gh_api_client::GhApiClient, jobserver_client::LazyJobserverClient,
lazy_gh_api_client::LazyGhApiClient, remote::Client,
},
manifests::cargo_toml_binstall::PkgOverride,
registry::Registry,
DesiredTargets,
@ -47,7 +50,7 @@ pub struct Options {
pub cargo_root: Option<PathBuf>,
pub client: Client,
pub gh_api_client: GhApiClient,
pub gh_api_client: LazyGhApiClient,
pub jobserver_client: LazyJobserverClient,
pub registry: Registry,