actions/cargo-binstall
1
0
Fork 0
mirror of https://github.com/cargo-bins/cargo-binstall.git synced 2025-06-08 03:36:37 +00:00
Code Issues Projects Releases Packages Wiki Activity

Improve use of github token (#1769)

Browse source 
* Add new dep zeroize

* Use Zeroizing to avoid leaking the token

* Optimize gh-auth-token

Spawn it as a task, and only await it
when using GhApiClient

* Fix binstalk-git-repo-api unit tests
This commit is contained in:
Jiahao XU 2024-06-15 15:42:09 +10:00 • committed by GitHub
parent e3c8c40806
commit fff6aa8122
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
13 changed files with 128 additions and 54 deletions
Download patch file Download diff file Expand all files Collapse all files

13
crates/bin/src/gh_token.rs
View file

@ -1,12 +1,13 @@
use std::{
io,
process::{Output, Stdio},
str,
};
use compact_str::CompactString;
use tokio::process::Command;
use zeroize::Zeroizing;
pub(super) async fn get() -> io::Result<CompactString> {
pub(super) async fn get() -> io::Result<Zeroizing<Box<str>>> {
let Output { status, stdout, .. } = Command::new("gh")
.args(["auth", "token"])
.stdin(Stdio::null())
@ -15,6 +16,8 @@ pub(super) async fn get() -> io::Result<CompactString> {
.output()
.await?;
let stdout = Zeroizing::new(stdout);
if !status.success() {
return Err(io::Error::new(
io::ErrorKind::Other,
@ -22,14 +25,12 @@ pub(super) async fn get() -> io::Result<CompactString> {
));
}
// Use String here instead of CompactString here since
// `CompactString::from_utf8` allocates if it's longer than 24B.
let s = String::from_utf8(stdout).map_err(|err| {
let s = str::from_utf8(&stdout).map_err(|err| {
io::Error::new(
io::ErrorKind::InvalidData,
format!("Invalid output, expected utf8: {err}"),
)
})?;
Ok(s.trim().into())
Ok(Zeroizing::new(s.trim().into()))
}