From ffe47d30c61b19486c620b04ca4081dc0903dac4 Mon Sep 17 00:00:00 2001 From: Jiahao XU Date: Tue, 28 May 2024 00:55:24 +1000 Subject: [PATCH] Rm unused `percent_encode_http_url_path` Signed-off-by: Jiahao XU --- .../src/gh_api_client/common.rs | 22 +------------------ 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/crates/binstalk-git-repo-api/src/gh_api_client/common.rs b/crates/binstalk-git-repo-api/src/gh_api_client/common.rs index 29d56d5a..091be43d 100644 --- a/crates/binstalk-git-repo-api/src/gh_api_client/common.rs +++ b/crates/binstalk-git-repo-api/src/gh_api_client/common.rs @@ -2,33 +2,13 @@ use std::{future::Future, sync::OnceLock, time::Duration}; use binstalk_downloader::remote::{self, header::HeaderMap, StatusCode, Url}; use compact_str::CompactString; -use percent_encoding::{ - percent_decode_str, utf8_percent_encode, AsciiSet, PercentEncode, CONTROLS, -}; +use percent_encoding::percent_decode_str; use serde::{de::DeserializeOwned, Deserialize, Serialize}; use serde_json::to_string as to_json_string; use tracing::debug; use super::{GhApiError, GhGraphQLErrors}; -pub(super) fn percent_encode_http_url_path(path: &str) -> PercentEncode<'_> { - /// https://url.spec.whatwg.org/#fragment-percent-encode-set - const FRAGMENT: &AsciiSet = &CONTROLS.add(b' ').add(b'"').add(b'<').add(b'>').add(b'`'); - - /// https://url.spec.whatwg.org/#path-percent-encode-set - const PATH: &AsciiSet = &FRAGMENT.add(b'#').add(b'?').add(b'{').add(b'}'); - - const PATH_SEGMENT: &AsciiSet = &PATH.add(b'/').add(b'%'); - - // The backslash (\) character is treated as a path separator in special URLs - // so it needs to be additionally escaped in that case. - // - // http is considered to have special path. - const SPECIAL_PATH_SEGMENT: &AsciiSet = &PATH_SEGMENT.add(b'\\'); - - utf8_percent_encode(path, SPECIAL_PATH_SEGMENT) -} - pub(super) fn percent_decode_http_url_path(input: &str) -> CompactString { if input.contains('%') { percent_decode_str(input).decode_utf8_lossy().into()