actions/cargo-binstall
1
0
Fork 0
mirror of https://github.com/cargo-bins/cargo-binstall.git synced 2025-06-16 23:56:37 +00:00
Code Issues Projects Releases Packages Wiki Activity

Refactor: Rm param auth_token for restful API fn

Browse source 
which is always set to `None`

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
This commit is contained in:
Jiahao XU 2024-05-28 23:12:02 +10:00
parent fc0222881c
commit f824ebbd9c
No known key found for this signature in database
GPG key ID: 76D1E687CA3C4928
4 changed files with 6 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

4
crates/binstalk-git-repo-api/src/gh_api_client.rs
View file

@ -166,7 +166,7 @@ impl GhApiClient {
) -> Result<U, GhApiError>
where
GraphQLFn: Fn(&remote::Client, &T, &str) -> GraphQLFut,
RestfulFn: Fn(&remote::Client, &T, Option<&str>) -> RestfulFut,
RestfulFn: Fn(&remote::Client, &T) -> RestfulFut,
GraphQLFut: Future<Output = Result<U, GhApiError>> + Send + Sync + 'static,
RestfulFut: Future<Output = Result<U, GhApiError>> + Send + Sync + 'static,
{
@ -181,7 +181,7 @@ impl GhApiClient {
}
}
restful_func(&self.0.client, data, None)
restful_func(&self.0.client, data)
.await
.map_err(|err| err.context("Restful API"))
}

12
crates/binstalk-git-repo-api/src/gh_api_client/common.rs
View file

@ -52,7 +52,6 @@ fn get_api_endpoint() -> &'static Url {
pub(super) fn issue_restful_api<T>(
client: &remote::Client,
path: &[&str],
auth_token: Option<&str>,
) -> impl Future<Output = Result<T, GhApiError>> + Send + Sync + 'static
where
T: DeserializeOwned,
@ -65,16 +64,11 @@ where
debug!("Getting restful API: {url}");
let mut request_builder = client
let future = client
.get(url)
.header("Accept", "application/vnd.github+json")
.header("X-GitHub-Api-Version", "2022-11-28");
if let Some(auth_token) = auth_token {
request_builder = request_builder.bearer_auth(&auth_token);
}
let future = request_builder.send(false);
.header("X-GitHub-Api-Version", "2022-11-28")
.send(false);
async move {
let response = future.await?;

2
crates/binstalk-git-repo-api/src/gh_api_client/release_artifacts.rs
View file

@ -72,7 +72,6 @@ pub(super) fn fetch_release_artifacts_restful_api(
repo: GhRepo { owner, repo },
tag,
}: &GhRelease,
auth_token: Option<&str>,
) -> impl Future<Output = Result<Artifacts, GhApiError>> + Send + Sync + 'static {
issue_restful_api(
client,
@ -80,7 +79,6 @@ pub(super) fn fetch_release_artifacts_restful_api(
"repos", owner, repo, "releases", "tags",
tag, //&percent_encode_http_url_path(tag).to_compact_string(),
],
auth_token,
)
}

3
crates/binstalk-git-repo-api/src/gh_api_client/repo_info.rs
View file

@ -34,9 +34,8 @@ impl RepoInfo {
pub(super) async fn fetch_repo_info_restful_api(
client: &remote::Client,
GhRepo { owner, repo }: &GhRepo,
auth_token: Option<&str>,
) -> Result<RepoInfo, GhApiError> {
issue_restful_api(client, &["repos", owner, repo], auth_token).await
issue_restful_api(client, &["repos", owner, repo]).await
}
#[derive(Deserialize)]