actions/cargo-binstall
1
0
Fork 0
mirror of https://github.com/cargo-bins/cargo-binstall.git synced 2025-04-24 22:30:03 +00:00
Code Issues Projects Releases Packages Wiki Activity

Avoid checking dev-deps for jobs *-check and lint in workflow ci.yml (#978)

Browse source 
Avoid checking dev-deps for jobs `*-check` and lint in workflow `ci.yml`

We just want to make sure cargo-binstall can compile for the target, we
don't want to pull in the extra dependencies.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
This commit is contained in:
Jiahao XU 2023-04-04 01:51:13 +10:00 • committed by GitHub
parent 8dd7aa5688
commit f384088fd1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
.github/workflows/ci.yml vendored
View file

@ -85,6 +85,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- run: just ci-install-deps - run: just ci-install-deps
- run: just avoid-dev-deps
- run: just check - run: just check
apple-m1-check: apple-m1-check:
@ -102,6 +103,7 @@ jobs:
# which works better when we provide it with GITHUB_TOKEN. # which works better when we provide it with GITHUB_TOKEN.
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- run: just avoid-dev-deps
- run: just check - run: just check
windows-aarch64-check: windows-aarch64-check:
@ -119,6 +121,7 @@ jobs:
# which works better when we provide it with GITHUB_TOKEN. # which works better when we provide it with GITHUB_TOKEN.
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- run: just avoid-dev-deps
- run: just check - run: just check
lint: lint:
@ -142,6 +145,7 @@ jobs:
- run: just toolchain rustfmt,clippy - run: just toolchain rustfmt,clippy
- run: just ci-install-deps - run: just ci-install-deps
- run: just avoid-dev-deps
- run: just lint - run: just lint
# Dummy job to have a stable name for the "all tests pass" requirement # Dummy job to have a stable name for the "all tests pass" requirement

8
justfile
View file

@ -220,6 +220,14 @@ fmt-check: fmt
lint: clippy fmt-check lint: clippy fmt-check
# Some dev-dependencies require a newer version of Rust, but it doesn't matter for MSRV check
# This is a workaround for the cargo nightly option `-Z avoid-dev-deps`
avoid-dev-deps:
for crate in ./crates/*; do \
sed 's/\[dev-dependencies\]/[workaround-avoid-dev-deps]/g' "$crate/Cargo.toml" >"$crate/Cargo.toml.tmp"; \
mv "$crate/Cargo.toml.tmp" "$crate/Cargo.toml" \
; done
package-dir: package-dir:
rm -rf packages/prep rm -rf packages/prep
mkdir -p packages/prep mkdir -p packages/prep