From eb77ad762bd38e522a30ced1bd6df1295a25ebb4 Mon Sep 17 00:00:00 2001 From: Jiahao XU Date: Thu, 30 May 2024 01:00:23 +1000 Subject: [PATCH] Refactor: `gh_api_client::test::create_client` shall not be `async` as there is no `.await` in it. Signed-off-by: Jiahao XU --- crates/binstalk-git-repo-api/src/gh_api_client.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/crates/binstalk-git-repo-api/src/gh_api_client.rs b/crates/binstalk-git-repo-api/src/gh_api_client.rs index 50a935d2..af0b2ab2 100644 --- a/crates/binstalk-git-repo-api/src/gh_api_client.rs +++ b/crates/binstalk-git-repo-api/src/gh_api_client.rs @@ -416,7 +416,7 @@ mod test { /// Mark this as an async fn so that you won't accidentally use it in /// sync context. - async fn create_client() -> Vec { + fn create_client() -> Vec { let client = create_remote_client(); let mut gh_clients = vec![GhApiClient::new(client.clone(), None)]; @@ -447,7 +447,7 @@ mod test { let mut tests: Vec<(_, _)> = Vec::new(); - for client in create_client().await { + for client in create_client() { for repo in PUBLIC_REPOS { let client = client.clone(); @@ -509,7 +509,7 @@ mod test { let mut tasks = Vec::new(); - for client in create_client().await { + for client in create_client() { for (release, artifacts) in RELEASES { for artifact_name in artifacts { let client = client.clone();