From d7ae1f242b2394e91961c448443c92edcc30c0d3 Mon Sep 17 00:00:00 2001 From: Jiahao XU Date: Thu, 21 Jul 2022 22:14:20 +1000 Subject: [PATCH] Optimize `Crates2Json::load_from_path`: Use `from_reader` which avoids reading the entire file into string at once. Signed-off-by: Jiahao XU --- src/metafiles/v2.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/metafiles/v2.rs b/src/metafiles/v2.rs index 3be0ead6..f4ea5573 100644 --- a/src/metafiles/v2.rs +++ b/src/metafiles/v2.rs @@ -47,8 +47,8 @@ impl Crates2Json { } pub fn load_from_path(path: impl AsRef) -> Result { - let file = fs::read_to_string(path)?; - Ok(serde_json::from_str(&file)?) + let file = fs::File::open(path.as_ref())?; + Ok(serde_json::from_reader(file)?) } pub fn insert(&mut self, cvs: CrateVersionSource, info: CrateInfo) {