actions/cargo-binstall
1
0
Fork 0
mirror of https://github.com/cargo-bins/cargo-binstall.git synced 2025-05-01 17:50:03 +00:00
Code Issues Projects Releases Packages Wiki Activity

Rm unnecessary warning msg "Failed to read git credential file" (#1479)

Browse source 
* Rm unnecessary warning msg "Failed to read git credential file"

Fixed #1476

If `gh auth token` executed successfully and binstall obtained a gh
token from it, then there's no reason to issue any warning msg.

Only when binstall cannot read from `.git-credential` and
`gh auth token` failed does binstall need to issue warning.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

* Fix clippy warning

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

---------

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
This commit is contained in:
Jiahao XU 2023-11-09 08:06:32 +10:00 • committed by GitHub
parent 3414c4ee83
commit d76a40bf7d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

18
crates/bin/src/git_credentials.rs
View file

@ -2,7 +2,6 @@ use std::{env, fs, path::PathBuf};
use compact_str::CompactString;
use dirs::home_dir;
use tracing::warn;
pub fn try_from_home() -> Option<CompactString> {
if let Some(mut home) = home_dir() {
@ -25,7 +24,8 @@ pub fn try_from_home() -> Option<CompactString> {
}
fn from_file(path: PathBuf) -> Option<CompactString> {
read_cred_file(path)?
fs::read_to_string(path)
.ok()?
.lines()
.find_map(from_line)
.map(CompactString::from)
@ -40,20 +40,6 @@ fn from_line(line: &str) -> Option<&str> {
Some(cred.split_once(':')?.1)
}
fn read_cred_file(path: PathBuf) -> Option<String> {
match fs::read_to_string(&path) {
Ok(s) => Some(s),
Err(err) => {
warn!(
?err,
"Failed to read git credential file {}",
path.display()
);
None
}
}
}
#[cfg(test)]
mod test {
use super::*;