actions/cargo-binstall
1
0
Fork 0
mirror of https://github.com/cargo-bins/cargo-binstall.git synced 2025-06-17 16:16:37 +00:00
Code Issues Projects Releases Packages Wiki Activity

Apply suggestions from code review

Browse source
This commit is contained in:
Jiahao XU 2024-06-10 00:24:53 +10:00 • committed by GitHub
parent a236f53121
commit d118412c2b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
crates/binstalk-git-repo-api/src/gh_api_client.rs
View file

@ -258,7 +258,6 @@ impl GhApiClient {
.await .await
{ {
Ok(artifacts) => { Ok(artifacts) => {
debug!("artifacts = {artifacts:?}");
Ok(Some(artifacts)) Ok(Some(artifacts))
} }
Err(GhApiError::NotFound) => Ok(None), Err(GhApiError::NotFound) => Ok(None),
@ -556,7 +555,7 @@ mod test {
)); ));
} }
if client.get_auth_token().is_some() { if client.has_auth_token() {
for repo in PRIVATE_REPOS { for repo in PRIVATE_REPOS {
let client = client.clone(); let client = client.clone();

2
crates/binstalk-git-repo-api/src/gh_api_client/release_artifacts.rs
View file

@ -78,7 +78,7 @@ pub(super) fn fetch_release_artifacts_restful_api(
client, client,
&[ &[
"repos", owner, repo, "releases", "tags", "repos", owner, repo, "releases", "tags",
tag, //&percent_encode_http_url_path(tag).to_compact_string(), tag,
], ],
) )
} }

2
e2e-tests/private-github-repo.sh
View file

@ -10,7 +10,7 @@ export PATH="$CARGO_HOME/bin:$PATH"
# Install binaries using `--manifest-path` # Install binaries using `--manifest-path`
# Also test default github template # Also test default github template
"./$1" binstall --force --manifest-path "manifests/private-github-repo-test-Cargo.toml" --no-confirm cargo-binstall --strategies crate-meta-data --log-level debug "./$1" binstall --force --manifest-path "manifests/private-github-repo-test-Cargo.toml" --no-confirm cargo-binstall --strategies crate-meta-data
# Test that the installed binaries can be run # Test that the installed binaries can be run
cargo binstall --help >/dev/null cargo binstall --help >/dev/null