mirror of
https://github.com/cargo-bins/cargo-binstall.git
synced 2025-05-06 12:10:02 +00:00
Fix fetcher::QuickInstall
stats report sending (#918)
Fixed https://github.com/cargo-bins/cargo-quickinstall/issues/195 - Fix `fetchers::QuickInstall`: Stop sending stats for `universal-apple-darwin` since quickinstall only supports targets officially supports by rust. - Only send stats report to quickinstall if the `Fetcher::find` is `.await`ed on This prevents stats report to be sent for cases where the `QuickInstall` fetcher is actually unused, e.g. resolved to `GhCrateMeta` or other `QuickInstall` fetcher with different target. This also reduces amount of http requests created in background. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
This commit is contained in:
parent
6843f478a9
commit
cc78ff3b90
3 changed files with 29 additions and 12 deletions
|
@ -118,6 +118,7 @@ async fn resolve_inner(
|
|||
);
|
||||
|
||||
for (fetcher, handle) in handles {
|
||||
fetcher.clone().report_to_upstream();
|
||||
match handle.flattened_join().await {
|
||||
Ok(true) => {
|
||||
// Generate temporary binary path
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue