actions/cargo-binstall
1
0
Fork 0
mirror of https://github.com/cargo-bins/cargo-binstall.git synced 2025-05-06 12:10:02 +00:00
Code Issues Projects Releases Packages Wiki Activity

Minor optimization (#544)

Browse source 
* Optimization: Rm `debug!` in `find_version`
   printing all version iterated obviously doesn't help much in debugging
   in the problem but rather just confusing.
   
   Also this makes it hard for the compiler to optimize the iterators.
* Use let-else in `ManifestVisitor`
* Optimize `BinFile::preview_{bin, link}` for zero-copy
   Return `impl Display` that lazily format instead of allocating a `String`
* Optimize `infer_bin_dir_template`: Generate dir lazily
* Optimize `find_version`: Lazily clone `version_req` only on err
* Refactor `find_version`: Use `bool::then_some`
* Add dep either v1.8.0 to binstalk
* Optimize `GhCrateMeta::find`: Avoid cloning and `Vec` creation
   by using `Either`
* Optimize `ops::install::install_from_package`: Make it a regular fn
   instead of async fn since it does not `.await` on any async fn.
* Optimize `QuickInstall`: Rm field `target`
   since `Arc<Data>` already contains that field.
* Optimize `Fetcher`s: Extract new struct `TargetData`
   so that `Data` can be shared by all fetchers, regardless of the target.
* Optimize `QuickInstall`: Rm unused field `data`
* Optimize `Resolution::print`: Replace branching with conditional move

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
This commit is contained in:
Jiahao XU 2022-11-21 08:32:46 +11:00 • committed by GitHub
parent 696d8c2a82
commit bdb4b2070d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 145 additions and 128 deletions
Download patch file Download diff file Expand all files Collapse all files

22
crates/binstalk/src/fetchers/quickinstall.rs
View file

@ -15,7 +15,7 @@ use crate::{
manifests::cargo_toml_binstall::{PkgFmt, PkgMeta},
};
use super::Data;
use super::{Data, TargetData};
const BASE_URL: &str = "https://github.com/alsuren/cargo-quickinstall/releases/download";
const STATS_URL: &str = "https://warehouse-clerk-tmp.vercel.app/api/crate";
@ -23,21 +23,23 @@ const STATS_URL: &str = "https://warehouse-clerk-tmp.vercel.app/api/crate";
pub struct QuickInstall {
client: Client,
package: String,
target: String,
data: Arc<Data>,
target_data: Arc<TargetData>,
}
#[async_trait::async_trait]
impl super::Fetcher for QuickInstall {
fn new(client: &Client, data: &Arc<Data>) -> Arc<dyn super::Fetcher> {
fn new(
client: Client,
data: Arc<Data>,
target_data: Arc<TargetData>,
) -> Arc<dyn super::Fetcher> {
let crate_name = &data.name;
let version = &data.version;
let target = data.target.clone();
let target = &target_data.target;
Arc::new(Self {
client: client.clone(),
client,
package: format!("{crate_name}-{version}-{target}"),
target,
data: data.clone(),
target_data,
})
}
@ -68,7 +70,7 @@ impl super::Fetcher for QuickInstall {
}
fn target_meta(&self) -> PkgMeta {
let mut meta = self.data.meta.clone();
let mut meta = self.target_data.meta.clone();
meta.pkg_fmt = Some(self.pkg_fmt());
meta.bin_dir = Some("{ bin }{ binary-ext }".to_string());
meta
@ -87,7 +89,7 @@ impl super::Fetcher for QuickInstall {
}
fn target(&self) -> &str {
&self.target
&self.target_data.target
}
}