From b69d8c25cb12e15ba6183592a297692f0d239a88 Mon Sep 17 00:00:00 2001 From: Jiahao XU Date: Wed, 22 Mar 2023 21:58:37 +1100 Subject: [PATCH] Enable `--no-symlinks` by default and fix `sccache` installation (#936) Partially resolve #731 Using symlinks not only add unnecessary bloat to users' `$CARGO_HOME/bin` directory, but it actually breaks `sccache`, which inspects its binary name and decides how to act on. For `sccache` to function, it must be invoked directly or use a hard link. Signed-off-by: Jiahao XU --- crates/bin/src/args.rs | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/crates/bin/src/args.rs b/crates/bin/src/args.rs index d234711b..cedab272 100644 --- a/crates/bin/src/args.rs +++ b/crates/bin/src/args.rs @@ -154,14 +154,10 @@ pub struct Args { #[clap(help_heading = "Overrides", long)] pub no_discover_github_token: bool, - /// Disable symlinking / versioned updates. + /// This flag is now enabled by default thus a no-op. /// - /// By default, Binstall will install a binary named `-` in the install path, and - /// either symlink or copy it to (depending on platform) the plain binary name. This makes it - /// possible to have multiple versions of the same binary, for example for testing or rollback. - /// - /// Pass this flag to disable this behavior. - #[clap(help_heading = "Options", long)] + /// By default, Binstall will install a binary as-is in the install path. + #[clap(help_heading = "Options", long, default_value_t = true)] pub no_symlinks: bool, /// Dry run, fetch and show changes without installing binaries.