actions/cargo-binstall
1
0
Fork 0
mirror of https://github.com/cargo-bins/cargo-binstall.git synced 2025-04-20 20:48:43 +00:00
Code Issues Projects Releases Packages Wiki Activity

Optimize GhCrateMeta::check: Avoid converting url to str

Browse source 
Only to convert it back to `Url` in `helpers::remote_exists`

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
This commit is contained in:
Jiahao XU 2022-06-07 15:40:55 +10:00
parent 0c83d010b1
commit b2a533dbdb
No known key found for this signature in database
GPG key ID: 591C0B03040416D6
3 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/fetchers/gh_crate_meta.rs
View file

@ -36,7 +36,7 @@ impl super::Fetcher for GhCrateMeta {
} }
info!("Checking for package at: '{url}'"); info!("Checking for package at: '{url}'");
remote_exists(url.as_str(), Method::HEAD).await remote_exists(url, Method::HEAD).await
} }
async fn fetch(&self, dst: &Path) -> Result<(), BinstallError> { async fn fetch(&self, dst: &Path) -> Result<(), BinstallError> {

2
src/fetchers/quickinstall.rs
View file

@ -30,7 +30,7 @@ impl super::Fetcher for QuickInstall {
let url = self.package_url(); let url = self.package_url();
self.report().await?; self.report().await?;
info!("Checking for package at: '{url}'"); info!("Checking for package at: '{url}'");
remote_exists(&url, Method::HEAD).await remote_exists(Url::parse(&url)?, Method::HEAD).await
} }
async fn fetch(&self, dst: &Path) -> Result<(), BinstallError> { async fn fetch(&self, dst: &Path) -> Result<(), BinstallError> {

3
src/helpers.rs
View file

@ -32,8 +32,7 @@ pub fn load_manifest_path<P: AsRef<Path>>(
Ok(manifest) Ok(manifest)
} }
pub async fn remote_exists(url: &str, method: Method) -> Result<bool, BinstallError> { pub async fn remote_exists(url: Url, method: Method) -> Result<bool, BinstallError> {
let url = Url::parse(url)?;
let req = reqwest::Client::new() let req = reqwest::Client::new()
.request(method.clone(), url.clone()) .request(method.clone(), url.clone())
.send() .send()