From abd50a72ecf176b372ea1c7a3f8df1770f015541 Mon Sep 17 00:00:00 2001
From: Jiahao XU <Jiahao_XU@outlook.com>
Date: Thu, 29 Sep 2022 00:51:11 +1000
Subject: [PATCH] Fix skipping optional dep: Skip fetcher if they provide 0 bin
 (#446)

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
---
 crates/binstalk/src/ops/resolve.rs | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/crates/binstalk/src/ops/resolve.rs b/crates/binstalk/src/ops/resolve.rs
index f47dccfc..1e24d1fe 100644
--- a/crates/binstalk/src/ops/resolve.rs
+++ b/crates/binstalk/src/ops/resolve.rs
@@ -243,13 +243,21 @@ async fn resolve_inner(
                 .await
                 {
                     Ok(bin_files) => {
-                        return Ok(Resolution::Fetch {
-                            fetcher,
-                            package,
-                            name: crate_name.name,
-                            version_req: version_req.to_compact_string(),
-                            bin_files,
-                        })
+                        if !bin_files.is_empty() {
+                            return Ok(Resolution::Fetch {
+                                fetcher,
+                                package,
+                                name: crate_name.name,
+                                version_req: version_req.to_compact_string(),
+                                bin_files,
+                            });
+                        } else {
+                            warn!(
+                                "Error when checking binaries provided by fetcher {}: \
+                                The fetcher does not provide any optional binary",
+                                fetcher.source_name(),
+                            );
+                        }
                     }
                     Err(err) => {
                         warn!(