actions/cargo-binstall
1
0
Fork 0
mirror of https://github.com/cargo-bins/cargo-binstall.git synced 2025-05-03 02:30:02 +00:00
Code Issues Projects Releases Packages Wiki Activity

More mionr optimizations (#553)

Browse source 
* Optimize `BinFile::preview_bin`: Use `Path::display` instead of `to_string_lossy` to avoid allocation.
* Refactor: Rm useless `AsRef::as_ref` call
* Optimize `GhCrateMeta::find`: Reduce fut size by converting `Url` to `String`
   `Url` is much larger than `String`.
* Refactor `PackageInfo::resolve`: Destruct `Meta::binstall`
* Optimize `resolve::load_manifest_path`: Avoid allocation

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
This commit is contained in:
Jiahao XU 2022-11-22 17:35:16 +11:00 • committed by GitHub
parent 707b173de1
commit 66abf1b8c1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 28 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

16
crates/binstalk/src/ops/resolve.rs
View file

@ -239,7 +239,10 @@ async fn resolve_inner(
}
}
/// * `fetcher` - `fetcher.find()` must return `Ok(true)`.
/// * `fetcher` - `fetcher.find()` must have returned `Ok(true)`.
///
/// Can return empty Vec if all `BinFile` is optional and does not exist
/// in the archive downloaded.
async fn download_extract_and_verify(
fetcher: &dyn Fetcher,
bin_path: &Path,
@ -278,7 +281,7 @@ async fn download_extract_and_verify(
}
}
// Verify that all the bin_files exist
// Verify that all non-optional bin_files exist
block_in_place(|| {
let bin_files = collect_bin_files(
fetcher,
@ -430,7 +433,7 @@ impl PackageInfo {
package
.metadata
.take()
.and_then(|mut m| m.binstall.take())
.and_then(|m| m.binstall)
.unwrap_or_default(),
manifest
.bin
@ -465,12 +468,13 @@ impl PackageInfo {
pub fn load_manifest_path<P: AsRef<Path>>(
manifest_path: P,
) -> Result<Manifest<Meta>, BinstallError> {
let manifest_path = manifest_path.as_ref();
block_in_place(|| {
let manifest_path = manifest_path.as_ref();
let manifest_path = if manifest_path.is_dir() {
manifest_path.join("Cargo.toml")
Cow::Owned(manifest_path.join("Cargo.toml"))
} else if manifest_path.is_file() {
manifest_path.into()
Cow::Borrowed(manifest_path)
} else {
return Err(BinstallError::CargoManifestPath);
};