From 563daa2bdd324025c5b98a8b95d1c3546e7f1ec4 Mon Sep 17 00:00:00 2001 From: Jiahao XU <30436523+NobodyXu@users.noreply.github.com> Date: Fri, 6 Jun 2025 01:00:17 +1000 Subject: [PATCH] Fix lifetime of `CratesToml<'::add_crate` API Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com> --- crates/binstalk-manifests/src/cargo_crates_v1.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/crates/binstalk-manifests/src/cargo_crates_v1.rs b/crates/binstalk-manifests/src/cargo_crates_v1.rs index c5c0991f..85a072d8 100644 --- a/crates/binstalk-manifests/src/cargo_crates_v1.rs +++ b/crates/binstalk-manifests/src/cargo_crates_v1.rs @@ -37,7 +37,7 @@ pub struct CratesToml<'a> { v1: Vec<(String, Cow<'a, [CompactString]>)>, } -impl CratesToml<'_> { +impl<'v1> CratesToml<'v1> { pub fn default_path() -> Result { Ok(cargo_home()?.join(".crates.toml")) } @@ -111,7 +111,7 @@ impl CratesToml<'_> { self.write_to_file(&mut file) } - pub fn add_crate<'this, 'metadata: 'this>(&'this mut self, metadata: &'metadata CrateInfo) { + pub fn add_crate(&mut self, metadata: &'v1 CrateInfo) { let name = &metadata.name; let version = &metadata.current_version; let source = Source::from(&metadata.source); @@ -138,7 +138,7 @@ impl CratesToml<'_> { c1.v1.reserve_exact(crates.len()); for metadata in crates { - self.add_crate(metadata); + c1.add_crate(metadata); } file.rewind()?;