From 54e6ca768f1d1a273bd8e9fd3e4074351069c097 Mon Sep 17 00:00:00 2001 From: Jiahao XU Date: Tue, 18 Jun 2024 23:22:22 +1000 Subject: [PATCH] Fix `binstalk-git-repo-api` Remove `Sync` bound on returned `Future`, since `tokio::spawn` does not require it Signed-off-by: Jiahao XU --- crates/binstalk-git-repo-api/src/gh_api_client.rs | 4 ++-- crates/binstalk-git-repo-api/src/gh_api_client/common.rs | 4 ++-- .../src/gh_api_client/release_artifacts.rs | 4 ++-- crates/binstalk-git-repo-api/src/gh_api_client/repo_info.rs | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/crates/binstalk-git-repo-api/src/gh_api_client.rs b/crates/binstalk-git-repo-api/src/gh_api_client.rs index b2e3d6a3..5b6420cf 100644 --- a/crates/binstalk-git-repo-api/src/gh_api_client.rs +++ b/crates/binstalk-git-repo-api/src/gh_api_client.rs @@ -204,8 +204,8 @@ impl GhApiClient { where GraphQLFn: Fn(&remote::Client, &T, &str) -> GraphQLFut, RestfulFn: Fn(&remote::Client, &T, Option<&str>) -> RestfulFut, - GraphQLFut: Future> + Send + Sync + 'static, - RestfulFut: Future> + Send + Sync + 'static, + GraphQLFut: Future> + Send + 'static, + RestfulFut: Future> + Send + 'static, { self.check_retry_after()?; diff --git a/crates/binstalk-git-repo-api/src/gh_api_client/common.rs b/crates/binstalk-git-repo-api/src/gh_api_client/common.rs index 35048e58..723834ec 100644 --- a/crates/binstalk-git-repo-api/src/gh_api_client/common.rs +++ b/crates/binstalk-git-repo-api/src/gh_api_client/common.rs @@ -39,7 +39,7 @@ pub(super) fn issue_restful_api( client: &remote::Client, path: &[&str], auth_token: Option<&str>, -) -> impl Future> + Send + Sync + 'static +) -> impl Future> + Send + 'static where T: DeserializeOwned, { @@ -95,7 +95,7 @@ pub(super) fn issue_graphql_query( client: &remote::Client, query: String, auth_token: &str, -) -> impl Future> + Send + Sync + 'static +) -> impl Future> + Send + 'static where T: DeserializeOwned + Debug, { diff --git a/crates/binstalk-git-repo-api/src/gh_api_client/release_artifacts.rs b/crates/binstalk-git-repo-api/src/gh_api_client/release_artifacts.rs index d11e2401..5b738842 100644 --- a/crates/binstalk-git-repo-api/src/gh_api_client/release_artifacts.rs +++ b/crates/binstalk-git-repo-api/src/gh_api_client/release_artifacts.rs @@ -74,7 +74,7 @@ pub(super) fn fetch_release_artifacts_restful_api( tag, }: &GhRelease, auth_token: Option<&str>, -) -> impl Future> + Send + Sync + 'static { +) -> impl Future> + Send + 'static { issue_restful_api( client, &["repos", owner, repo, "releases", "tags", tag], @@ -135,7 +135,7 @@ pub(super) fn fetch_release_artifacts_graphql_api( tag, }: &GhRelease, auth_token: &str, -) -> impl Future> + Send + Sync + 'static { +) -> impl Future> + Send + 'static { let client = client.clone(); let auth_token = auth_token.to_compact_string(); diff --git a/crates/binstalk-git-repo-api/src/gh_api_client/repo_info.rs b/crates/binstalk-git-repo-api/src/gh_api_client/repo_info.rs index ac5c08cc..d95cca81 100644 --- a/crates/binstalk-git-repo-api/src/gh_api_client/repo_info.rs +++ b/crates/binstalk-git-repo-api/src/gh_api_client/repo_info.rs @@ -55,7 +55,7 @@ pub(super) fn fetch_repo_info_restful_api( client: &remote::Client, GhRepo { owner, repo }: &GhRepo, auth_token: Option<&str>, -) -> impl Future, GhApiError>> + Send + Sync + 'static { +) -> impl Future, GhApiError>> + Send + 'static { issue_restful_api(client, &["repos", owner, repo], auth_token) } @@ -68,7 +68,7 @@ pub(super) fn fetch_repo_info_graphql_api( client: &remote::Client, GhRepo { owner, repo }: &GhRepo, auth_token: &str, -) -> impl Future, GhApiError>> + Send + Sync + 'static { +) -> impl Future, GhApiError>> + Send + 'static { let query = format!( r#" query {{