Fix installer downloads for specific releases (#1976)

* Fix installer downloads for specific releases

Github download urls for a specific release uses the pattern `../releases/download/[RELEASE]/..`, which differs from the latest release URL which uses `../releases/latest/download/..`.

For convenience, if `BINSTALL_VERSION` is set but doesn't start with `v`, the v is prefixed.

* ci: Set BINSTALL_VERSION in install script tests

When running the install-script workflow in Github Actions, add matrix
options for not setting the variable, setting it to the latest release
with the `v` prefix, and setting it to the latest release without the
`v` prefix.
This commit is contained in:
Martijn Pieters 2024-11-20 08:08:08 +00:00 committed by GitHub
parent 2417642284
commit 266e627928
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 65 additions and 5 deletions

View file

@ -2,11 +2,21 @@
set -euxo pipefail
BINSTALL_VERSION="${BINSTALL_VERSION:-latest}"
if [[ -n "${BINSTALL_VERSION:-}" && "$BINSTALL_VERSION" != v* ]]; then
# prefix version with v
BINSTALL_VERSION="v$BINSTALL_VERSION"
fi
cd "$(mktemp -d)"
base_url="https://github.com/cargo-bins/cargo-binstall/releases/${BINSTALL_VERSION}/download/cargo-binstall-"
# Fetch binaries from `[..]/releases/latest/download/[..]` if _no_ version is
# given, otherwise from `[..]/releases/download/VERSION/[..]`. Note the shifted
# location of '/download'.
if [[ -z "${BINSTALL_VERSION:-}" ]]; then
base_url="https://github.com/cargo-bins/cargo-binstall/releases/latest/download/cargo-binstall-"
else
base_url="https://github.com/cargo-bins/cargo-binstall/releases/download/${BINSTALL_VERSION}/cargo-binstall-"
fi
os="$(uname -s)"
if [ "$os" == "Darwin" ]; then