actions/cargo-binstall
1
0
Fork 0
mirror of https://github.com/cargo-bins/cargo-binstall.git synced 2025-06-07 19:26:36 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix updating of installed crates manifest on custom sparse registry (#2178)

Browse source 
* Add either v1.15.0 to binstalk-registry

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Add `SourceType::Sparse`

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Add `Registry::crate_source`

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Use `Registry::crate_siouy

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Add support for `Source::Sparse`

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Optimize `CratesToml::append_to_file`

Bulkify remove

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix typing in cargo_crates_v1.rs and optimize append_to_file

Use `Vec::reserve_exact ` in `append_to_file` to avoid unnecessary allocation

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix Registry::url

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix unused variable in `Registry::crate_source`

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix fmt in cargo_crates_v1.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix fmt in binstalk-registry/src/lib.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix fmt in cargo_crates_v1.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Refactor: Extract new fn CratesToml::add_crate

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix `<Source as Display>::fmt` impl for `Source::Sprase`

Add `/` to the end of the url if it doesn't have one

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix crate_version_source.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix lifetime of `CrateToml::add_crate` API

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix lifetime of `CratesToml<'::add_crate` API

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* cargo fmt crate_version_source.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix `Registery::crate_source`

Match sparse/git crates.io registry to standardrised `CrateSource::cratesio_registry()`.

Also optimize it to avoid unnecessary `.to_string()` and `Url::parse` for sparse registry.

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix `GitRegistry::url` ret type

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix `SparseRegistery::url` return type

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Fix typing in `Registry::crate_source`

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Rm unused import in sparse_registry.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Rm unused import in git_registry.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* cargo fmt binstalk-registry/src/lib.rs

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

* Rm unused dep either from binstalk-registry

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

---------

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
This commit is contained in:
Jiahao XU 2025-06-06 14:13:05 +10:00 • committed by GitHub
parent e8c9cc3599
commit 25a52038ef
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 101 additions and 56 deletions
Download patch file Download diff file Expand all files Collapse all files

12
crates/binstalk/src/ops/resolve.rs
View file

@ -496,17 +496,7 @@ impl PackageInfo {
.fetch_crate_matched(client, &name, version_req),
)
.await?,
{
let registry = format!("{}", opts.registry);
if registry == "https://index.crates.io/" {
CrateSource::cratesio_registry()
} else {
CrateSource {
source_type: SourceType::Registry,
url: MaybeOwned::Owned(Url::parse(&registry)?),
}
}
},
opts.registry.crate_source()?,
),
};