Rm unused param temp_dir from install_from_package

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
This commit is contained in:
Jiahao XU 2022-07-20 16:59:23 +10:00
parent 1ebd4bdb75
commit 1eedae1ee2
No known key found for this signature in database
GPG key ID: 591C0B03040416D6

View file

@ -286,7 +286,6 @@ async fn entry(jobserver_client: jobserver::Client) -> Result<()> {
tokio::spawn(install( tokio::spawn(install(
resolution, resolution,
opts.clone(), opts.clone(),
temp_dir_path.clone(),
desired_targets.clone(), desired_targets.clone(),
jobserver_client.clone(), jobserver_client.clone(),
)) ))
@ -312,20 +311,13 @@ async fn entry(jobserver_client: jobserver::Client) -> Result<()> {
crate_name, crate_name,
desired_targets.clone(), desired_targets.clone(),
cli_overrides, cli_overrides,
temp_dir_path.clone(), temp_dir_path,
install_path, install_path,
client, client,
) )
.await?; .await?;
install( install(resolution, opts, desired_target, jobserver_client).await
resolution,
opts,
temp_dir_path,
desired_target,
jobserver_client,
)
.await
}) })
}) })
.collect() .collect()
@ -563,7 +555,6 @@ fn collect_bin_files(
async fn install( async fn install(
resolution: Resolution, resolution: Resolution,
opts: Arc<Options>, opts: Arc<Options>,
temp_dir: Arc<Path>,
desired_targets: DesiredTargets, desired_targets: DesiredTargets,
jobserver_client: jobserver::Client, jobserver_client: jobserver::Client,
) -> Result<()> { ) -> Result<()> {
@ -582,7 +573,7 @@ async fn install(
source: metafiles::Source::cratesio_registry(), source: metafiles::Source::cratesio_registry(),
}; };
install_from_package(fetcher, opts, cvs, temp_dir, version, bin_path, bin_files).await install_from_package(fetcher, opts, cvs, version, bin_path, bin_files).await
} }
Resolution::InstallFromSource { package } => { Resolution::InstallFromSource { package } => {
let desired_targets = desired_targets.get().await; let desired_targets = desired_targets.get().await;
@ -603,12 +594,10 @@ async fn install(
} }
} }
#[allow(unused, clippy::too_many_arguments)]
async fn install_from_package( async fn install_from_package(
fetcher: Arc<dyn Fetcher>, fetcher: Arc<dyn Fetcher>,
opts: Arc<Options>, opts: Arc<Options>,
cvs: metafiles::CrateVersionSource, cvs: metafiles::CrateVersionSource,
temp_dir: Arc<Path>,
version: String, version: String,
bin_path: PathBuf, bin_path: PathBuf,
bin_files: Vec<bins::BinFile>, bin_files: Vec<bins::BinFile>,