From 1c3a67210846c9cc17a3493661a113778f8f19ab Mon Sep 17 00:00:00 2001 From: Jiahao XU Date: Fri, 10 Jun 2022 13:52:11 +1000 Subject: [PATCH] Rm `scopeguard` creatd for `mpsc::Receiver` Since `Receiver` always closes on drop, there is no need to call `Receiver::close`, which is there so that you can close the mpsc channel without dropping `Receiver`. Signed-off-by: Jiahao XU --- src/helpers/async_extracter.rs | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/helpers/async_extracter.rs b/src/helpers/async_extracter.rs index 4eed3276..a35dec91 100644 --- a/src/helpers/async_extracter.rs +++ b/src/helpers/async_extracter.rs @@ -37,14 +37,9 @@ impl AsyncExtracterInner { desired_outputs: Option<[Cow<'static, Path>; N]>, ) -> Self { let path = path.to_owned(); - let (tx, rx) = mpsc::channel::(100); + let (tx, mut rx) = mpsc::channel::(100); let handle = AutoAbortJoinHandle::new(spawn_blocking(move || { - // close rx on error so that tx.send will return an error - let mut rx = guard(rx, |mut rx| { - rx.close(); - }); - fs::create_dir_all(path.parent().unwrap())?; match fmt {