actions/cargo-binstall
1
0
Fork 0
mirror of https://github.com/cargo-bins/cargo-binstall.git synced 2025-04-20 20:48:43 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #152 from passcod/warn-on-http

Browse source 
Warn on non-HTTPS URLs
This commit is contained in:
Félix Saparelli 2022-06-01 01:11:01 +12:00 • committed by GitHub
commit 13a8e1e5fe
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/fetchers/gh_crate_meta.rs
View file

@ -1,6 +1,6 @@
use std::path::Path; use std::path::Path;
use log::{debug, info}; use log::{debug, info, warn};
use reqwest::Method; use reqwest::Method;
use serde::Serialize; use serde::Serialize;
use url::Url; use url::Url;
@ -28,6 +28,11 @@ impl super::Fetcher for GhCrateMeta {
async fn check(&self) -> Result<bool, BinstallError> { async fn check(&self) -> Result<bool, BinstallError> {
let url = self.url()?; let url = self.url()?;
if url.scheme() != "https" {
warn!("URL is not HTTPS! This may become a hard error in the future, tell the upstream!");
}
info!("Checking for package at: '{url}'"); info!("Checking for package at: '{url}'");
remote_exists(url.as_str(), Method::HEAD).await remote_exists(url.as_str(), Method::HEAD).await
} }