From 0f7828569a893559373f7994c2a6a243b1fbe65f Mon Sep 17 00:00:00 2001 From: Jiahao XU Date: Thu, 17 Aug 2023 09:13:21 +1000 Subject: [PATCH] Add `error` logging if achieve doesn't contain bin required (#1298) * Add `error` logging if achieve doesn't contain bin required So that users know that this is an upstream issue and will report to upstream. Signed-off-by: Jiahao XU * Update crates/binstalk/src/ops/resolve.rs --------- Signed-off-by: Jiahao XU --- crates/binstalk/src/ops/resolve.rs | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/crates/binstalk/src/ops/resolve.rs b/crates/binstalk/src/ops/resolve.rs index 1261574a..3ca6c902 100644 --- a/crates/binstalk/src/ops/resolve.rs +++ b/crates/binstalk/src/ops/resolve.rs @@ -14,7 +14,7 @@ use maybe_owned::MaybeOwned; use semver::{Version, VersionReq}; use tempfile::TempDir; use tokio::task::spawn_blocking; -use tracing::{debug, info, instrument, warn}; +use tracing::{debug, error, info, instrument, warn}; use crate::{ bins, @@ -267,17 +267,22 @@ async fn download_extract_and_verify( // This binary is optional Err(err) => { let required_features = &bin.required_features; + let bin_name = bin.name.as_str(); if required_features.is_empty() { + error!( + "When resolving {name} bin {bin_name} is not found.\ +This binary is not optional so it must be included in the archive, please contact with\ +upstream to fix this issue." + ); // This bin is not optional, error Some(Err(err)) } else { // Optional, print a warning and continue. - let bin_name = bin.name.as_str(); let features = required_features.iter().format(","); warn!( "When resolving {name} bin {bin_name} is not found. \ - But since it requies features {features}, this bin is ignored." +But since it requies features {features}, this bin is ignored." ); None }