actions/cargo-binstall
1
0
Fork 0
mirror of https://github.com/cargo-bins/cargo-binstall.git synced 2025-06-07 03:06:37 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix zip extraction and bins::infer_bin_dir_template (#869)

Browse source 
- Fix zip extraction code: Ensure dir is rwx and file is readable for curr user
 - Add more integration test for `ExtractedFiles`
 - Fix `bins::infer_bin_dir_template` introduced in #856

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
This commit is contained in:
Jiahao XU 2023-03-06 17:54:31 +11:00 • committed by GitHub
parent 460522f5bd
commit 01c8ecb778
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 56 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

12
crates/binstalk-downloader/src/download/zip_extraction.rs
View file

@ -54,17 +54,25 @@ where
// Get permissions
let mut perms = None;
let is_dir = raw_filename.ends_with('/');
#[cfg(unix)]
{
use std::{fs::Permissions, os::unix::fs::PermissionsExt};
if let Some(mode) = zip_reader.entry().unix_permissions() {
let mode: u16 = mode;
// If it is a dir, then it needs to be at least rwx for the current
// user so that we can create new files, search for existing files
// and list its contents.
//
// If it is a file, then it needs to be at least readable for the
// current user.
let mode: u16 = mode | if is_dir { 0o700 } else { 0o400 };
perms = Some(Permissions::from_mode(mode as u32));
}
}
if raw_filename.ends_with('/') {
if is_dir {
extracted_files.add_dir(&filename);
// This entry is a dir.